Skip to content

fuzz: handle missing SendTx* message events in chanmon_consistency#4496

Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
joostjager:fix-fuzz-missing-msgs
Mar 20, 2026
Merged

fuzz: handle missing SendTx* message events in chanmon_consistency#4496
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
joostjager:fix-fuzz-missing-msgs

Conversation

@joostjager
Copy link
Contributor

Add handlers for SendTxInitRbf, SendTxAckRbf, SendTxRemoveInput, and SendTxRemoveOutput in the chanmon_consistency fuzz target. These variants were reachable but not matched, causing panics on the wildcard arm ("Unhandled message event").

SendTxInitRbf became reachable after commit 5873660 added splicing support without updating the fuzz target's message delivery logic.

AI tools were used in preparing this commit.

Add handlers for SendTxInitRbf, SendTxAckRbf, SendTxRemoveInput, and
SendTxRemoveOutput in the chanmon_consistency fuzz target. These
variants were reachable but not matched, causing panics on the wildcard
arm ("Unhandled message event").

SendTxInitRbf became reachable after commit 5873660 added splicing
support without updating the fuzz target's message delivery logic.

AI tools were used in preparing this commit.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 19, 2026

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@TheBlueMatt
Copy link
Collaborator

Makes sense to me. Why is this draft?

@joostjager
Copy link
Contributor Author

I left it to the splicing people to take over. But if Claude one-shotted it, I can take it out of draft.

@joostjager joostjager marked this pull request as ready for review March 20, 2026 17:28
@joostjager joostjager removed the request for review from valentinewallace March 20, 2026 17:37
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@TheBlueMatt TheBlueMatt merged commit d830f10 into lightningdevkit:main Mar 20, 2026
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants